Only upload a singly synchronous packed slab when buffer is reached #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
force-pushed
the
pj/fix-packed-slab-uploads
branch
from
121133c
to
9fcbe97
Compare
There was a problem hiding this comment.
Lgtm now but it would be nice to extend the worker tests with a way to test this. e.g. by mocking the bus in a way that allows for manually adding packed slabs and setting the buffer size and then uploading an object to make sure the packed slabs get uploaded too.
…cked-slab-uploads
…cked-slab-uploads
ChrisSchinnerl
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how it snuck in but when the buffer max size is reached, we keep uploading packed slabs synchronously until the context eventually times out. That's not what we want, we want to upload a single packed slab synchronously to ensure the buffer goes down, and spin a background thread that eats away at the rest.