Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: renterd alert improvements and reset account drift #538

Merged
merged 1 commit into from Mar 25, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Mar 22, 2024

Alerts improvements, primarily the addition of an account context menu and refined display of contract set change data.

  • Account alerts now feature an accounts context menu with the option to reset account drift.
  • The contract set change alert data fields are now displayed as one field that shows additions and removals for each contract in one timeline.
  • Fixed an issue where the alerts list would trigger an excessive number of API calls to fetch contract and host metadata.
  • Table now has row specific cell class name props that do not apply to the table header.
  • Context menus now all use a caret icon.
  • Added useAccountResetDrift.
Screenshot 2024-03-22 at 2 27 20 PM Screenshot 2024-03-22 at 2 14 11 PM Screenshot 2024-03-22 at 11 20 57 AM

Copy link

changeset-bot bot commented Mar 22, 2024

🦋 Changeset detected

Latest commit: 2d2f9cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siafoundation/react-renterd Minor
renterd Minor
@siafoundation/design-system Minor
hostd Minor
walletd Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexfreska and the rest of your teammates on Graphite Graphite

@alexfreska alexfreska self-assigned this Mar 22, 2024
@alexfreska alexfreska marked this pull request as ready for review March 22, 2024 18:31
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

My only nit would be that this PR could probably be multiple. I'll leave it up to you whether you want to incorporate some of PJ's changes from Discord in this PR or in a f/u to get the other changes merged and iterate on the alert dialog separately.

Also assigning PJ since he had a few good ideas

@alexfreska
Copy link
Member Author

Lgtm

My only nit would be that this PR could probably be multiple. I'll leave it up to you whether you want to incorporate some of PJ's changes from Discord in this PR or in a f/u to get the other changes merged and iterate on the alert dialog separately.

Also assigning PJ since he had a few good ideas

Agreed, this turned into a group of alerts improvements, but I should have separated out account drift at the very least, will try to avoid next time 👍🏼

I will do a follow up with PJ's changes to make the edits more clear.

@alexfreska alexfreska merged commit 1053c50 into main Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants