Add extra check when resolving INFOPLIST_FILE and fail with a meaningful error message

[iby]

This takes care when INFOPLIST_FILE setting fails to resolve, which can happen here and here without an actual error raised.

[iby]

This is partly a continuation of my quest with #13. Looks like it's failing because of a very old fastlane. Can we upgrade it to something higher?

[SiarheiFedartsou]

@ianbytchek Thanks for excellent improvement!
It is a one of the first plugins for fastlane, so fastlane version is really old :) And, yes, of course, we can update it. Could you do it?

[iby]

This isn't outdated Fastlane… Before I dig further can you help me out a little?

Here you have:

path = plist.gsub('$(SRCROOT)', project.path.parent.to_path)
path = path.gsub('${SRCROOT}', project.path.parent.to_path)

This is what failing current tests – when variables are resolved it simply returns SRCROOT, not $(SRCROOT). I'd expect it to be an actual expanded path, but instead Xcodeproj returns variable name.

Do you know anything about this? Why? Doesn't Xcodeproj know that path?

P. S. I can simply gsub for SRCROOT, not $(SRCROOT), but it feels hacky in this case. So, would like to get to the bottom of this.

[iby]

🚦 @SiarheiFedartsou green light! I went ahead with gsubing approach since it's a hack either way and chances are people having SRCROOT in their INFOPLIST_FILE are zero to none. 🤞

[iby]

@SiarheiFedartsou 👋 Can we merge this? Rebased everything onto the latest version. Looks good from my end.

[SiarheiFedartsou]

@ianbytchek Yes, of course, we can. And maybe you want to be a maintainer of this repo? :) Unfortunately, for now I don't have enough time to support this plugin...

[iby]

Feel free to add me to the maintainers list. I know my way a around the project a little, will contribute with what I can! 👍

[SiarheiFedartsou]

@ianbytchek Thanks for accepting this proposition :) Added you as collaborator for now. As I understood it is the only thing that I can do without moving this repo to another account/organization. But it will be enough to support it.