Fixes increment_build_number_in_xcodeproj in xocde 11

[prathmeshranaut]

Error

23:35:08: --- Step: increment_build_number_in_xcodeproj ---
23:35:08: -------------------------------------------------
[23:35:09]: Unknown method 'plist'
[23:35:09]: To call another action from an action use other_action.plist instead
+------+-------------------------------------+-------------+
| fastlane summary |
+------+-------------------------------------+-------------+
| Step | Action | Time (in s) |
+------+-------------------------------------+-------------+
| 💥 | increment_build_number_in_xcodeproj | 0 |
+------+-------------------------------------+-------------+
[23:35:09]: fastlane finished with errors
[!] To call another action from an action use other_action.plist instead

Fastfile to reproduce

lane :increment do
  increment_build_number_in_xcodeproj(
    xcodeproj: '<your-xcodeproject>',
    target: <target>,
    build_configuration_name: <Release>
  )
end

Fix

Looks like an incorrect comparison. The plugin works fine after the change.

[prathmeshranaut]

Fixes #47

[giacomoRanieri]

Can someone accept the pull request and release a new version? I need the fix for my project.

[jdouglas-nz]

@giacomoRanieri for now could you pls just target @prathmeshranaut 's fork? I'm grateful for his work but I'd love for him to add a test to make sure we never regress this again. I will look at this tonight or tomorrow if he hasn't already🤞

[jdouglas-nz]

weren't there any unit tests that were testing the old -- albeit incorrect - method ? do you still have a green light?

[jdouglas-nz]

@prathmeshranaut / @giacomoRanieri / @shuima101 I have released this fix. please give it a go and tell me how you go. Apologies for the very slow response time on this one.

[KeiroMidori]

Works for me. Thanks!