Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignore configuration when we use increment_build_number or increment_app_version in xcodeproj with target and build_configuration_name #69

Merged
merged 4 commits into from
Jun 25, 2022

Conversation

skiritsa
Copy link
Contributor

This pull request fixes an issue when we use increment_build_number_in_xcodeproj or increment_version_number_in_xcodeproj passing in the target and build_configuration_name options. Before the fix, action changed values in both configurations at once

@skiritsa skiritsa changed the title Fix ignore configuration when increment build number and app version in xcodeproj with target Fix ignore configuration when we use increment_build_number or increment_app_version in xcodeproj with target and build_configuration_name Dec 29, 2021
@jdouglas-nz
Copy link
Collaborator

jdouglas-nz commented Apr 18, 2022

oof. sorry I missed this ! I was wondering if you'd mind adding a couple unit tests to cover this behaviour please? 🙇 I see these still pass all the tests, and what you've said about this does make sense. merging and releasing. thank you for your contribution!

@jdouglas-nz jdouglas-nz merged commit 44c1929 into SiarheiFedartsou:master Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants