Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed issue when GPX file has only a timestamp on the first point. #27

Merged
merged 2 commits into from
Mar 6, 2018
Merged

fixed issue when GPX file has only a timestamp on the first point. #27

merged 2 commits into from
Mar 6, 2018

Conversation

roynijkamp
Copy link
Contributor

Added check if lastPoint->time exists.

@Sibyx
Copy link
Owner

Sibyx commented Mar 6, 2018

Thanks for your PR, can you please add also check if the $lastPoint->time is an instance of \DateTime just to be sure?

@roynijkamp
Copy link
Contributor Author

Sibyx, i just added the check for instance of \DateTime

@Sibyx Sibyx self-requested a review March 6, 2018 12:25
@Sibyx Sibyx merged commit edd7b3e into Sibyx:master Mar 6, 2018
@Sibyx
Copy link
Owner

Sibyx commented Mar 6, 2018

Looks good to me, merging. Thank you for your contribution

@Sibyx Sibyx mentioned this pull request Mar 6, 2018
Closed
@Sibyx Sibyx mentioned this pull request Feb 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sibyx Sibyx Sibyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roynijkamp @Sibyx