Tests and fixes #8124
Tests and fixes #8124
Conversation
miigotu
force-pushed
the
tests
branch
5 times, most recently
from
bb6a4fb
to
dd7953c
Compare
|
This pull request fixes 1 alert when merging 65f510d into bf7ca8b - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 933169a into b2b09e3 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging 371a186 into 0c8d40a - view on LGTM.com fixed alerts:
|
|
This fixes #7978 for sure @Linden-Ryuujin (as long as you have one piece set as anime) but there are some other things in here we need to test, like that I got irritated with not being able to debug correctly and removed the poetry_install stuff lol |
| @@ -438,23 +439,20 @@ def already_processed(process_path, video_file, force, result): | |||
|
|
|||
| # Needed if we have downloaded the same episode @ different quality | |||
| # But we need to make sure we check the history of the episode we're going to PP, and not others | |||
| try: # if it fails to find any info (because we're doing an unparsable folder (like the TV root dir) it will throw an exception, which we want to ignore | |||
| parse_result = NameParser(process_path, tryIndexers=True).parse(process_path) | |||
There was a problem hiding this comment.
@BKSteve, no more spam to indexers =P
|
This pull request fixes 2 alerts when merging f3e6d7c into 0c8d40a - view on LGTM.com fixed alerts:
|
yup, this got rid of the drv_libxml2 error, everything working fine EDIT: i was a little to quick on that |
|
This pull request fixes 2 alerts when merging 1c72d67 into 32108d7 - view on LGTM.com fixed alerts:
|
|
The Nyaa site isn't getting but site https://nyaa.si/?page=rss&c=1_0&s=id&o=desc&f=2&q=Sekai+no+Owari+ni+Shiba+Inu+to+16 using same string provides don't know enough / no time ATM to track this down the filtering of one to the other. |
|
This pull request fixes 2 alerts when merging c5f2d52 into 57da5c4 - view on LGTM.com fixed alerts:
|
Fixed in 0fde830 |
Signed-off-by: miigotu <miigotu@gmail.com>
Signed-off-by: miigotu <miigotu@gmail.com>
…foreign languages. Default is the|a|an, but for example spanish would be "un|una|el|la|los|las"
Can be set in config->general or under the Localization domain in the config.ini
Fixes #8081
Signed-off-by: miigotu <miigotu@gmail.com>
…r result for anime Signed-off-by: miigotu <miigotu@gmail.com>
Signed-off-by: miigotu <miigotu@gmail.com>
…d hackiness for it. Guides need updated to instruct people how to install dependencies! Signed-off-by: miigotu <miigotu@gmail.com>
…file, first parse it with guessit and see if we can find the show to match it to. If so, we know to only use anime regexes or regular regexes. Fallback to old way otherwise. Fix up some logging in post processor and processTV Signed-off-by: miigotu <miigotu@gmail.com>
Signed-off-by: miigotu <miigotu@gmail.com>
…odd poetry-date-version-plugin references from their source Signed-off-by: miigotu <miigotu@gmail.com>
Signed-off-by: miigotu <miigotu@gmail.com>
|
This pull request fixes 2 alerts when merging e12ce20 into 57da5c4 - view on LGTM.com fixed alerts:
|
Not going to lie I'm struggling to launch sickchill with poetry on Win11 with virtualenv What I had to do on linux (had issue with python3-poetry (1.12) and pip3 install as root wants to uninstall packages) with venv: on Windows11 with python3.10 from MS store it need to run with this is not working for windows with python from MS store, many PATH issues, |
|
html5lib isn't supposed to be required though. We need to use a try/except to allow it of it's there and ignore it if it isn't. I thought I had caught all the places for that. You are doing this with the tests branch right? |
|
@pigsyn I just checked, and it does say "No module named 'html5lib'" but it starts and runs anyway right after that
|
|
@pigsyn aha, I found that poetry itself wants html5lib lol #This reinstalls html5lib
pip install "poetry>=1.2.0" |
Signed-off-by: miigotu <miigotu@gmail.com>
…n rss searches Signed-off-by: miigotu <miigotu@gmail.com>
… think Signed-off-by: miigotu <miigotu@gmail.com>
|
This pull request fixes 3 alerts when merging 24102cf into 57da5c4 - view on LGTM.com fixed alerts:
|
Signed-off-by: miigotu <miigotu@gmail.com>
|
This pull request fixes 3 alerts when merging 5737f5e into 57da5c4 - view on LGTM.com fixed alerts:
|
|
Looking into errors on Syno box with latest develop. This looks to be the cause: The env is correct location and .venv doesn't exist, all packages in correct location. cut the standard lines Poetry is installed under Suggestions or things I need to check? |
I had this subprocess and no such file error when I tried to start develop with systemctl without using poetry, I'll recheck |
|
I put the `shell=True' in line 156 and it can run
|
|
It's the same on ubuntu Works if you activate venv and pip install poetry_date_version_plugin But maybe it's an issue ? |
|
Yes. On DSM I installed the |
|
I'll make some commits hopefully tomorrow |
|
@BKSteve the syno package needs updated to use a pip install. The git updater and source updater are being removed. Tired of taking bandaids off one by one, may as well break everything that needs broken all at once so this is hopefully the last time. We will only be checking the importlib.metadata (as designed by standard python practice) for versioning, which requires the package to actually be installed. Switching between master and develop will be handled by running for example SickChill, or SickChill-develop, they will be packaged separately on pypi. Syno is the last package still using a source install or git install. We need a unified install method. |
|
@miigotu yes it will need an update. The above was to just get the current way working. |
|
It's not going to self update anymore after the next release to master until the syno package is reworked, but maybe that's ok. I loathe the self updating anyway, if someone has pip they should be able to |
|
Maybe the syno package itself should be rebuilt for each SC release, with the package version set as the SC version and the SC from pypi pinned to the version, so the update shows in the syno package manager instead. I could automatically check out the syno package source and edit it in GitHub actions maybe, and make a PR to synocommunity on each release. It's just 2 sed or tee lines once the package is set up for that. |
|
Once I've finished the get SC on DSM step by step I'll work on it. |
I'll help with it also, sync your synocommunity fork and open a PR to your own fork and tag me. Once we get it nice we can change the target of the PR to synocommunity to get it merged. This is a high priority item, before I release develop. |
This should fix #8104 @kyuuk could you please test?