Fix rootdir #1
Merged
Fix rootdir #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork
sync with Sids master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sid, like this we can prevent specifying the root_dir already in strax but rather doing it in straxen. This was what I was suggesting in your PR AxFoundation#300.
You may wonder why I committed 0d9724d:
CodeFactor will prevent you from merging the PR. This is some stupid unrelated issue because it thinks you are storing passwords. However if we fix another 'issue' we can merge the PR.
@SidAhmedMa if you give the ok (or merge this PR yourself) I think your PR would be good to go