fixed rubocop offense, slightly increased max classlength

SidOfc · Apr 29, 2017 · 7d32075 · 7d32075
1 parent a8dc6dd
commit 7d32075
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -30,7 +30,7 @@ Metrics/AbcSize:
 
 Metrics/ClassLength:
   CountComments: false
-  Max: 150
+  Max: 175
 
 Metrics/MethodLength:
   CountComments: false

diff --git a/lib/browserino/client.rb b/lib/browserino/client.rb
@@ -107,8 +107,8 @@ def to_json(*args)
     def to_s
       @str_cache ||= %i[name engine platform].map do |prop|
         n = properties[prop]
-        v = properties[prop == :name ? :version : "#{prop}_version".to_sym]
-        l = properties[prop == :name ? :label : "#{prop}_label".to_sym]
+        v = version_for prop
+        l = label_for prop
         a = l ? l : [n, (v.major if v > '0.0.0')].join.to_sym
 
         [n, a].uniq
@@ -140,6 +140,16 @@ def respond_to_missing?(_, *__, &___)
 
     private
 
+    def name_for(sym)
+      mtd = %i[version label].include?(sym) ? :name : "#{sym}_name".to_sym
+      properties[mtd]
+    end
+
+    def label_for(sym)
+      mtd = %i[version name].include?(sym) ? :label : "#{sym}_label".to_sym
+      properties[mtd]
+    end
+
     def version_for(sym)
       mtd = %i[label name].include?(sym) ? :version : "#{sym}_version".to_sym
       properties[mtd]