Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demons blade talent DH #833

Closed
Hemario opened this issue Jan 27, 2021 · 3 comments
Closed

Demons blade talent DH #833

Hemario opened this issue Jan 27, 2021 · 3 comments

Comments

@Hemario
Copy link
Contributor

Hemario commented Jan 27, 2021

Demons blade talent makes demons_bite into a passive. However, Ovale still shows the icon.
Some weird replaced_by logic is going on in the spells.ts file.

[967] >>> Computing 'spell(demons_bite)' at time=102486.941000
[967]    evaluating action: spell()
[966] >>> Computing 'demons_bite' at time=102486.941000
[966]    value is 344859
[966] <<< 'demons_bite' returns (0, inf) with computed value 344859 + (t - 0) * 0
[302] >>> Computing 'specialization("havoc")' at time=102486.941000
[301] >>> Computing '"havoc"' at time=102486.941000
[301] <<< '"havoc"' returns (0, inf) with constant value "havoc"
[302]    condition 'specialization' returns 0, inf, nil, nil, nil
[302] <<< 'specialization("havoc")' returns (0, inf) with computed none
[300] >>> Computing 'value' at time=102486.941000
[300]    value is 162243
[300] <<< 'value' returns (0, inf) with computed value 162243 + (t - 0) * 0
[306] >>> Computing 'specialization("vengeance")' at time=102486.941000
[305] >>> Computing '"vengeance"' at time=102486.941000
[305] <<< '"vengeance"' returns (0, inf) with constant value "vengeance"
[306]    condition 'specialization' returns nil, nil, nil, nil, nil
[306] <<< 'specialization("vengeance")' returns empty set with computed none
[304] >>> Computing 'value' at time=102486.941000
[304]    value is 203782
[304] <<< 'value' returns (0, inf) with computed value 203782 + (t - 0) * 0
Spell ID '344859' is replaced by spell ID '162243'.
Action not found for spell ID '162243'; checking for replaced spell ID '344859'.
Spell ID '162243' is not known; checking for replaced spell ID '344859'.
Spell ID '344859' requires 0.000000 seconds for power requirements.
Spell ID '344859' meets power requirements.
OvaleSpells:IsUsableSpell(344859, 102486.941000, nil) returned true, false
Didn't find an existing cd in next, look for one in current
Call GetSpellCooldown which returned 0.000000, 0.000000, 1
It returned -0.100000, 0.000000
Spell cooldown is in the past
Cooldown of spell 344859 is 0.000000 + 0.000000
GetSpellCooldown returned 0.000000, 0.000000
Spell cooldown is in the past
Cooldown of spell 344859 is 0.000000 + 0.000000
Spell ID '344859' requires 0.000000 seconds for power requirements.
[967]    Action spell still has 0.000000 charges but is on GCD (start=0.000000).
[967]    start=0.000000 atTime=102486.941000
[967]    Action spell is waiting for the global cooldown.
[967]    Action spell can start at 102486.941000.
[967] <<< 'spell(demons_bite)' returns (102486.941, inf) with computed action spell 344859
@Hemario
Copy link
Contributor Author

Hemario commented Jan 27, 2021

image

@johnnylam88
Copy link
Contributor

I guess we should follow the chain of replaced_by to the end.

johnnylam88 added a commit to johnnylam88/Ovale that referenced this issue Jan 28, 2021
When a spell is annotated to be replaced by another spell using the
SpellInfo parameter 'replaced_by', keep searching along the chain
of spells for other 'replaced_by' directives until we reach the
final replacement spell.

This should fix issue Sidoine#833.
Sidoine pushed a commit that referenced this issue Jan 31, 2021
)

* fix: follow 'replaced_by' SpellInfo chain to the final replacement

When a spell is annotated to be replaced by another spell using the
SpellInfo parameter 'replaced_by', keep searching along the chain
of spells for other 'replaced_by' directives until we reach the
final replacement spell.

This should fix issue #833.

* style: rename MAX_GUARD to maxGuard to silence lint
@johnnylam88
Copy link
Contributor

This can be closed.

@Sidoine Sidoine closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants