-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demons blade talent DH #833
Comments
I guess we should follow the chain of |
johnnylam88
added a commit
to johnnylam88/Ovale
that referenced
this issue
Jan 28, 2021
When a spell is annotated to be replaced by another spell using the SpellInfo parameter 'replaced_by', keep searching along the chain of spells for other 'replaced_by' directives until we reach the final replacement spell. This should fix issue Sidoine#833.
Sidoine
pushed a commit
that referenced
this issue
Jan 31, 2021
) * fix: follow 'replaced_by' SpellInfo chain to the final replacement When a spell is annotated to be replaced by another spell using the SpellInfo parameter 'replaced_by', keep searching along the chain of spells for other 'replaced_by' directives until we reach the final replacement spell. This should fix issue #833. * style: rename MAX_GUARD to maxGuard to silence lint
This can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Demons blade talent makes demons_bite into a passive. However, Ovale still shows the icon.
Some weird replaced_by logic is going on in the spells.ts file.
The text was updated successfully, but these errors were encountered: