fix(power): fix semantics of {max,set,refund}_XXX in SpellInfo() #835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
set_<powerType>
is given in SpellInfo(), use that as thevalue to which the power should be set after the spell is
successfully cast. Ensure that the cost of the spell given by
<powerType>
is met even ifset_<powerType>
is given.If
max_<powerType>
is given in SpellInfo(), use that as the maxcost of the spell. Use
getProperty()
instead of directlyaccessing the value so that any spell requirements are handled at
runtime. Note that power cost from
set_<powerType>
hasprecedence over the cost from
max_<powerType>
.Lastly, always evaluate
refund_<powerType>
to determine theamount of power refunded after the spell is successfully cast.
With this change, a combo-point finisher spell can be defined in
two different ways:
SpellInfo(finisher combopoints=1 set_combopoints=0)
or
SpellInfo(finisher combopoints=1 max_combopoints=5)