improve logging statistics

Sieboldianus · Sep 4, 2019 · 7391712 · 7391712
1 parent d7685e5
commit 7391712
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 8 deletions.
diff --git a/lbsntransform/__main__.py b/lbsntransform/__main__.py
@@ -115,15 +115,16 @@ def main():
                     break
         except Exception as e:
             # catch any exception and output additional information
-            print(
+            lbsntransform.log.warning(
                 f"\nError while reading records: "
                 f"{e}\n{e.args}\n{traceback.format_exc()}\n")
-            print(f"Current source: \n {input_data.current_source}\n")
+            lbsntransform.log.warning(
+                f"Current source: \n {input_data.current_source}\n")
             stats_str = HF.report_stats(
                 input_data.count_glob,
                 input_data.continue_number,
                 lbsntransform.lbsn_records)
-            print(stats_str)
+            lbsntransform.log.warning(stats_str)
 
     # finalize output (close db connection, submit remaining)
     lbsntransform.log.info(
@@ -138,9 +139,13 @@ def main():
         f'(Input {input_data.start_number} to '
         f'{input_data.continue_number}). '
         f'\n\nIdentified {lbsntransform.processed_total} LBSN records, '
-        f'with {lbsntransform.lbsn_records.count_glob_total} distinct LBSN records overall. '
+        f'with {lbsntransform.lbsn_records.count_glob_total} '
+        f'distinct LBSN records overall. '
         f'{HF.get_skipped_report(input_data.import_mapper)}. '
-        f'Merged {lbsntransform.lbsn_records.count_dup_merge_total} duplicate records.')
+        f'Merged {lbsntransform.lbsn_records.count_dup_merge_total} '
+        f'duplicate records.')
+    lbsntransform.log.info(
+        f'\n{HF.get_count_stats(lbsntransform.lbsn_records)}')
 
     lbsntransform.log.info(f'Done. {how_long.stop_time()}')
 

diff --git a/lbsntransform/classes/helper_functions.py b/lbsntransform/classes/helper_functions.py
@@ -90,9 +90,16 @@ def report_stats(input_cnt, current_cnt, lbsn_records):
         report_stats = (f'{input_cnt} '
                         f'input records processed (up to '
                         f'{current_cnt}). '
-                        f'Count per type: '
-                        f'{lbsn_records.get_type_counts()}'
-                        f'records.')
+                        f'{HelperFunctions.get_count_stats(lbsn_records)}')
+        return report_stats
+
+    @staticmethod
+    def get_count_stats(lbsn_records):
+        """Format string for reporting count stats."""
+        report_stats = (
+            f'Count per type: '
+            f'{lbsn_records.get_type_counts()}'
+            f'records.')
         return report_stats
 
     @staticmethod