New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types for swipe & swipe-map control #109

Merged

Siedlerchr merged 2 commits into Siedlerchr:master from felhe:fix/swipe-control-types

Oct 27, 2022

Contributor

felhe commented Oct 24, 2022

Hi, some small changes to the types of both swipe controls:

A typo in the definition for options.orientation led to type errors when using the constructor options.
Both the swipe & swipe map control were missing some options, e.g. using an array of layers besides a single layer. It was already missing in the original JSDoc comments in ol-ext, so I opened a PR over there: docs: update options in jsdoc for swipe & swipe-map control Viglino/ol-ext#879.

This PR is ready as soon as the upstream PR is merged.

felhe added 2 commits

October 25, 2022 01:19


          docs: update types for layers in swipe control options

64fef13


          docs: add missing option to swipe map control

0574b94

Owner

Siedlerchr commented Oct 25, 2022

Thank you very much! I hope to take a look at it soon

Siedlerchr marked this pull request as ready for review

October 27, 2022 16:46

Siedlerchr merged commit ecffd3e into Siedlerchr:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment