Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct Chart's Options interface. improve code style. #132

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix: correct Chart's Options interface. improve code style. #132

merged 1 commit into from
Jun 21, 2023

Conversation

bradenbiz
Copy link
Contributor

@bradenbiz bradenbiz commented Jun 21, 2023 •
edited by Siedlerchr

Fixes #131

@bradenbiz bradenbiz mentioned this pull request Jun 21, 2023
Closed
@Siedlerchr
Copy link
Owner

Thanks! Seems like the javadoc should be improved here as well to include data:
https://github.com/Viglino/ol-ext/blob/d29ad18b8a7fc38e88f59a0718db6a527e61eae3/src/style/Chart.js#L34

@Siedlerchr Siedlerchr merged commit 2036e55 into Siedlerchr:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chart is incorrect and mispelled
2 participants
@bradenbiz @Siedlerchr