Improvements for setting custom flags, and logging #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrisgoffinet
commented
Sep 20, 2021
•
chrisgoffinet
commented
- Support loading environment variables from tailscale-env so you can set flags
- Support logging tailscaled to a file under /mnt/data/tailscale/tailscaled.log
* Support loading environment variables from tailscale-env so you can set flags * Support logging tailscaled to a file under /mnt/data/logs/tailscaled.log
|
Thank you for putting this together, it looks like a great addition to the script. I noticed that shellcheck is failing on the PR and, if you have a chance to fix those warnings before I merge, I'd really appreciate it (alternatively I'm happy to do so if you don't have the time). |
|
@notheotherben should be good to go now! |
|
Wonderful, thank you so much for putting this together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.