Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peggy2 protobuf files need to be compatible with peggy1 #3357

Closed
banshee opened this issue Nov 1, 2022 · 2 comments
Closed

Peggy2 protobuf files need to be compatible with peggy1 #3357

banshee opened this issue Nov 1, 2022 · 2 comments
Assignees
@juniuszhou
Labels
Peggy Team Peggy team task Peggy 2.0 An issue blocking the Peggy 2.0 release

Comments

@banshee
Copy link
Contributor

banshee commented Nov 1, 2022

There are some instances where peggy2 changed the type of proto fields, and that's not legal. Need to fix them.
@banshee banshee added the Peggy 2.0 An issue blocking the Peggy 2.0 release label Nov 1, 2022
@juniuszhou juniuszhou self-assigned this Nov 3, 2022
@pandaring2you
Copy link
Contributor

PR Ready for review: sifnode#3359

@juniuszhou
Copy link
Contributor

close it after PR #3359 merged.

@pandaring2you pandaring2you added the Peggy Team Peggy team task label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juniuszhou juniuszhou

Labels
Peggy Team Peggy team task Peggy 2.0 An issue blocking the Peggy 2.0 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@banshee @juniuszhou @pandaring2you