Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services_JSON is using deprecated PHP 4 style constructors #24

Closed
sjelfull opened this issue Jan 3, 2016 · 3 comments
Closed

Services_JSON is using deprecated PHP 4 style constructors #24

sjelfull opened this issue Jan 3, 2016 · 3 comments

Comments

@sjelfull
Copy link
Contributor

sjelfull commented Jan 3, 2016

I'm using the library under PHP 7.0, and i'm seeing this error message: Methods with the same name as their class will not be constructors in a future version of PHP (See list of deprecated features)

@Lagg
Copy link

Lagg commented Jan 12, 2016

I can confirm this bug, and it's nothing short of hilarious that your simple commit hasn't been merged yet. Guess it's time for a mail.

@fredsadaghiani
Copy link
Contributor

@Lagg @sjelfull My apologies. We'll get working on these right away. There was a miscommunication on our side about who would address these fixes. We'll get them resolved tonight (PST).

yschatzberg pushed a commit that referenced this issue Jan 12, 2016
Fixes #24 - Deprecated PHP4 style constructors
@yschatzberg
Copy link
Contributor

@Lagg @sjelfull Thank you for finding and fixing this bug, and apologies for the delay on merging the PR. We'd love to send you each a T-shirt if you're interested. If you shoot me an email at yoav at siftscience dot com with your t-shirt size and an address to ship to we'll get them to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants