Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use json_* functions if possible #17

Merged
merged 2 commits into from
Jan 13, 2015
Merged

Conversation

grachov
Copy link
Contributor

@grachov grachov commented Sep 25, 2014

No description provided.

@yschatzberg
Copy link
Contributor

Hi @grachov,

Could you explain why you prefer requiring JSON.php within the function rather than at the head of the file?

@grachov
Copy link
Contributor Author

grachov commented Nov 1, 2014

I think it's rare case when somebody has no json_* functions available, so that file will be included only for those users.

@fredsadaghiani
Copy link
Contributor

ping

yschatzberg pushed a commit that referenced this pull request Jan 13, 2015
Use json_* functions if possible
@yschatzberg yschatzberg merged commit da7e1d3 into SiftScience:master Jan 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants