Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(For Janice) Adds logging, updates libs, fixes tests #52

Merged
merged 2 commits into from
Sep 13, 2017
Merged

(For Janice) Adds logging, updates libs, fixes tests #52

merged 2 commits into from
Sep 13, 2017

Conversation

garylee1
Copy link
Contributor

@garylee1 garylee1 commented Sep 12, 2017 •
edited
Loading

@KaoruDev

cc @vaidas-lungis @tiagobutzke

@garylee1
Copy link
Contributor Author

Also incorporates various other outstanding PR changes.

This was referenced Sep 12, 2017
Closed
Closed
This was referenced Sep 12, 2017
Closed
Closed
vaidas-lungis
vaidas-lungis approved these changes Sep 13, 2017
View reviewed changes
Copy link

@vaidas-lungis vaidas-lungis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@garylee1 garylee1 changed the title (For Kaoru) Adds logging, updates libs, fixes tests (For Janice) Adds logging, updates libs, fixes tests Sep 13, 2017
@garylee1 garylee1 requested review from janiceblue and removed request for KaoruDev September 13, 2017 22:59
janiceblue
janiceblue approved these changes Sep 13, 2017
View reviewed changes
Copy link

@janiceblue janiceblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garylee1 garylee1 merged commit ef8e881 into master Sep 13, 2017
@garylee1 garylee1 deleted the gary_add_logger branch September 13, 2017 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janiceblue janiceblue janiceblue approved these changes

@vaidas-lungis vaidas-lungis vaidas-lungis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garylee1 @janiceblue @vaidas-lungis