(for Nick) Switch to CircleCI #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehrmann
commented
Mar 22, 2019
| @@ -29,13 +29,12 @@ | |||
| "email": "support@siftscience.com" | |||
| }, | |||
| "require": { | |||
| "php": ">=5.0.0" | |||
| "php": ">=7.1.0" | |||
There was a problem hiding this comment.
php5 support was dropped on 2019-01-01: http://php.net/supported-versions.php
ehrmann
commented
Mar 22, 2019
| @@ -433,7 +1484,8 @@ | |||
| "prefer-stable": false, | |||
| "prefer-lowest": false, | |||
| "platform": { | |||
| "php": ">=5.0.0" | |||
| "php": ">=5.0.0", | |||
| "ext-curl": "*" | |||
There was a problem hiding this comment.
sift-php explicitly uses php curl
ehrmann
force-pushed
the
dehrmann_circleci
branch
from
e2aa2ce
to
4f146d6
Compare
ehrmann
force-pushed
the
dehrmann_circleci
branch
from
4f146d6
to
6d97191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a few changes fixing build issues and adding support in CircleCI: