Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSUE-161] #93

Merged
merged 10 commits into from
Jun 2, 2023
Merged

[MSUE-161] #93

merged 10 commits into from
Jun 2, 2023

Conversation

Toji-Thomas
Copy link
Contributor

@Toji-Thomas Toji-Thomas commented Mar 9, 2023

Recreated PR #77 and #73 without conflicts.
Also added,
• array syntax changes in other files too
• added missing private properties.

Copy link

@vincent-sift vincent-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for the verifications check and resend methods, as these were referenced in the Jira ticket?

lib/SiftResponse.php Show resolved Hide resolved
@viaskal-sift viaskal-sift changed the title [MSUE-164] [OUTDATED][MSUE-164] Mar 10, 2023
@Toji-Thomas Toji-Thomas changed the title [OUTDATED][MSUE-164] [MSUE-161] Mar 16, 2023
@binish-exalture
Copy link

PR looks good and is ready of merge.

Copy link

@binish-exalture binish-exalture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch looks good and ready for merge.

@viaskal-sift viaskal-sift merged commit f3f2090 into SiftScience:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants