-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSUE-161] #93
[MSUE-161] #93
Conversation
… made those common, added commandline env var support
…without conflict)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for the verifications check and resend methods, as these were referenced in the Jira ticket?
PR looks good and is ready of merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch looks good and ready for merge.
Recreated PR #77 and #73 without conflicts.
Also added,
• array syntax changes in other files too
• added missing private properties.