Update deprecated syntax in SiftClient.php #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With newest php version this causes a lot of deprecation notices. Please use correct syntax from now on.
Closed
|
Solves #96 |
|
Many of us would be very thankful if this gets released asap as this deprecation warning generates tons of unnecessary logs throughout systems. |
|
@TheLevti thanks for raising this, we will review and release it soon |
|
@TheLevti we already merged some changes to the master after you created your PR - could you pls update from master so that it is up-to-date and we can proceed with merging? |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary
Testing
Checklist