fix: do not route back to overview tab when changing the resource attributes #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
2 similar comments
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
vikrantgupta25
force-pushed
the
fix-routing-tab-change
branch
from
3dc5ff5
to
d8eb44a
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
vikrantgupta25
force-pushed
the
fix-routing-tab-change
branch
from
d66cc34
to
75242c8
Compare
YounixM
force-pushed
the
fix-routing-tab-change
branch
from
75242c8
to
73b0094
Compare
vikrantgupta25
force-pushed
the
fix-routing-tab-change
branch
from
73b0094
to
a1de063
Compare
srikanthccv
approved these changes
May 27, 2024
YounixM
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
overviewtab in case changing theresource attributescurrently, the query params were getting overridden therefore causing the issue. Now appending to the params instead of overriding the sameRelated Issues / PR's
fixes #5050
Screenshots
NA
Affected Areas and Manually Tested Areas