Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endless Decision "Occupation of the Congo" #158

Open
SGDynamo1953 opened this issue Jan 21, 2019 · 2 comments · May be fixed by #174
Open

Endless Decision "Occupation of the Congo" #158

SGDynamo1953 opened this issue Jan 21, 2019 · 2 comments · May be fixed by #174

Comments

@SGDynamo1953
Copy link

Hello guys, I am very new to Github and not at all familiar with it, so please tell me if I'm doing something wrong here ;)

I've experienced France taking the decision to occupy the Congo (occupation_of_the_congo within FlavourMod_Africa) endlessly. I believe it has to do with the possibility to add further provinces later on, which makes flag-setting somewhat more challenging. I'm not that good (yet, at least I hope) at modding decisions and events so I don't know the best way to solve this. Any ideas?
@Suprcheese
Copy link

I, too, have observed this decision being nigh-endlessly spammed...

@ImperatorAugustus
Copy link

+1

moretrim pushed a commit to moretrim/HFM that referenced this issue Mar 10, 2020
@rogerburks @moretrim
Add missing requirement to Occupation of the Congo
8cf03ca 
Closes SighPie#158.

The mismatch between the decision requirements and the test performed in
the actual effects resulted in decision spam.
moretrim added a commit to moretrim/HFM that referenced this issue Mar 10, 2020
@moretrim
Harmonise requirements & effects
6493790 
A caretaker follow-up patch. This does not alter the semantics of the
decision, but is designed to help future changes avoid a repeat of SighPie#158.

Opening a split view of the file to look at both the `allow` and
`effect` blocks simultaneously can help understand this change, as the
diff is somewhat noisy.
@moretrim moretrim linked a pull request Mar 10, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Occupation of the congo requirements moretrim/HFM
3 participants
@Suprcheese @ImperatorAugustus @SGDynamo1953