Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix for rule regex #4860

Merged
merged 6 commits into from
May 27, 2024
Merged

Minor fix for rule regex #4860

merged 6 commits into from
May 27, 2024

Conversation

CR-OfirTal
Copy link
Contributor

Summary of the Pull Request

Just adding a bracket to the regex

Changelog

fix: Dynamic .NET Compilation Via Csc.EXE - small regex fix
fix: Csc.EXE Execution Form Potentially Suspicious Parent - small regex fix

Example Log Event

Fixed Issues

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

@github-actions github-actions bot added Rules Windows Pull request add/update windows related rules labels May 21, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @CR-OfirTal 👋

It looks like this is your first pull request on the Sigma rules repository!

Please make sure to read the SigmaHQ conventions document to make sure your contribution is adhering to best practices and has all the necessary elements in place for a successful approval.

Thanks again, and welcome to the Sigma community! 😃

@frack113
Copy link
Member

Hi,
Thanks for the fix.
As the regex fix change the detection the field modified must be updated.

@nasbench nasbench merged commit 4163fde into SigmaHQ:master May 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rules Windows Pull request add/update windows related rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants