Remove input_channel argument from ValueConsumer #706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a command handler for providing routes
Rename ConstantSensor getters and setters
Unsupported since v1...
Use native ESP-IDF logging
Fix empty config list
This make connect_to and O(N) operation with respect to the number of existing observers, but the call order of the observers is now the same as the insertion order. Also, adding new observers usually happens in the setup stage of program execution, in which the added performance penalty is not relevant.
Throttle limits the update rate of its input.
This might break some transforms.
|
Wrong destination branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValueConsumer input_channels were implemented to allow multiple inputs to a single transform. However, the semantics were never fully thought out, and the argument was used very rarely. Since you can achieve the same result by adding multiple LambdaConsumers in a single class, I've decided to remove the input_channel argument altogether. This might break some transforms temporarily.