feat: Allow for users without password #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the security code to allow for users to be configured in `security.json` without a password value. These users can then only be logged in with using the `signalk-generate-token` script. Fixes SignalK#1714.
|
I think this should have a test in security tests to go with it. Care to add one, please? |
|
@tkurki I've added tests as requested. |
rhbvkleef
commented
Apr 16, 2024
rhbvkleef
force-pushed
the
1714-users-without-passwords
branch
from
e2069bf
to
45c2952
Compare
|
Looking good! Just one more thing, eslint errors in tokensecurity, and then we should be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the security code to allow for users to be configured in
security.jsonwithout a password value. These users can then only be logged in with using thesignalk-generate-tokenscript.Fixes #1714.