Add changelog generation #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RegEx for the urn was not being enforced as the additionalProperties had not been set to False, allowing any other format of property to be acceptable. Also once turned on there were some urns which passed through the RegEx but which are clearly wrong: urn:mrn:imo:mmsi:2300999990 (mmsi too long) urn:mrn:signalk:uuid:c0d79334-4e25-4245-8892-54e8ccc8021de (uuid too long) urn:mrn:imo:uuid:c0d79334-4e25-4245-8892-54e8ccc8021d (mixed mmsi/uuid) urn:mrn:signalk:mmsi:212345678 (mixed mmsi/uuid) I have not addressed the following 'bad' vessel urns as I'm not sure whether the decision to allow poorly formed email addresses was deliberate or not: mailto:fred http://a string with anything you like Also simplified the definition for mmsi as maxLength & minLength are not required as they are already defined by the RegEx.
Schema fails validation against http://json-schema.org/draft-04/schema# due to "required" being in the wrong place.
Some of the samples had errors which prevented them from validating against the schema. "source" replaced with "$source", version added, urn included, mmsi format corrected, meta/zones corrected and alarm methods corrected as appropriate.
The timestamp now has to be in date-time format. As a result quite a few test data and sample files had to be updated along with a test js file which had json embedded for test purposes.
Also changed the reference from ISO 8601 to RFC 3339 which is the format SK is using. RFC 3339 is just one of the possible ISO 8601 formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.