This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Fixes to support distributed scenario #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| OnMessage(Id, message); | ||
| OnMessage(Id, message); | ||
| } | ||
| catch (Exception) { } |
There was a problem hiding this comment.
The DeserializeObject call blows up when the worker's SignalR clients write trace messages to standard output. When we tried sending these messages back to the TestController, the agent was crashing (I presume due to some kind of concurrency issue).
Switching to Streamer should eliminate the need to deal with these exceptions, but there is still the question of what to do with the client trace information.
|
|
| @@ -33,13 +32,13 @@ public Agent() | |||
| Trace.WriteLine("Agent created"); | |||
| } | |||
|
|
|||
| public async Task Run() | |||
| public async Task Run(string url) | |||
Fixed concurrency issue with worker connections. Catching json exceptions
mikary
force-pushed
the
managerParameter
branch
from
128033d
to
00d2b5c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameter for TestController to allow agents to connect to remote host
-Using CmdLine package to simplify argument parsing #17
Catching exceptions from Json serializer that caused agent to crash when worker trace messages are written to standard output
Using thread-safe collection for worker connections
Force copy of Microsoft.Web.Infrastructure.dll to run TestController app on full IIS - Not GAC'd
@abnanda1 @davidfowl