Ack timeout is too short under stress scenarios.

- Bumped ack timeout to 30 seconds. - Made ack handler public so it's easy to override the timeout. #1435
SignalR · Feb 10, 2013 · 34f518f · 34f518f
1 parent 0f4c191
commit 34f518f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/Microsoft.AspNet.SignalR.Core/Infrastructure/AckHandler.cs b/src/Microsoft.AspNet.SignalR.Core/Infrastructure/AckHandler.cs
@@ -2,12 +2,13 @@
 
 using System;
 using System.Collections.Concurrent;
+using System.Diagnostics.CodeAnalysis;
 using System.Threading;
 using System.Threading.Tasks;
 
 namespace Microsoft.AspNet.SignalR.Infrastructure
 {
-    internal class AckHandler : IAckHandler, IDisposable
+    public class AckHandler : IAckHandler, IDisposable
     {
         private readonly ConcurrentDictionary<string, AckInfo> _acks = new ConcurrentDictionary<string, AckInfo>();
 
@@ -18,12 +19,13 @@ internal class AckHandler : IAckHandler, IDisposable
         private Timer _timer;
 
         public AckHandler()
-            : this(completeAcksOnTimeout: true, 
-                   ackThreshold: TimeSpan.FromSeconds(5),
+            : this(completeAcksOnTimeout: true,
+                   ackThreshold: TimeSpan.FromSeconds(30),
                    ackInterval: TimeSpan.FromSeconds(5))
         {
         }
 
+        [SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly", MessageId = "Acks", Justification = "Ack is a well known term")]
         public AckHandler(bool completeAcksOnTimeout, TimeSpan ackThreshold, TimeSpan ackInterval)
         {
             if (completeAcksOnTimeout)