Re-enabled groups rejoining test and modified hub callabck cleared test

#2273
SignalR · Jul 29, 2013 · 94fe1c1 · 94fe1c1
1 parent ee49fe2
commit 94fe1c1
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/src/Microsoft.AspNet.SignalR.Client/HubConnection.cs b/src/Microsoft.AspNet.SignalR.Client/HubConnection.cs
@@ -102,10 +102,6 @@ protected override void OnMessageReceived(JToken message)
                     {
                         _callbacks.Remove(result.Id);
                     }
-                    else
-                    {
-                        Debug.Assert(false, "Callback with id " + result.Id + " not found!");
-                    }
                 }
 
                 if (callback != null)

diff --git a/tests/Microsoft.AspNet.SignalR.Client.Tests/Client/HubProxyFacts.cs b/tests/Microsoft.AspNet.SignalR.Client.Tests/Client/HubProxyFacts.cs
@@ -179,10 +179,7 @@ public void HubCallbackClearedOnFailedInvocation()
             var ex = aggEx.Unwrap();
 
             Assert.IsType(typeof(TaskCanceledException), ex);
-
-            // We want to wait for the callbacks to be cleared
-            Thread.Sleep(2 * 1000);
-
+
             Assert.Equal(connection.Object._callbacks.Count, 0);
         }
     }

diff --git a/tests/Microsoft.AspNet.SignalR.FunctionalTests/Server/Hubs/HubFacts.cs b/tests/Microsoft.AspNet.SignalR.FunctionalTests/Server/Hubs/HubFacts.cs
@@ -928,7 +928,7 @@ public void AddingToMultipleGroups(HostType hostType, TransportType transportTyp
             }
         }
 
-        [Theory(Skip = "The reconnect logic has changed. These tests need to be revisited")]
+        [Theory]
         [InlineData(HostType.Memory, TransportType.ServerSentEvents, MessageBusType.Default)]
         [InlineData(HostType.Memory, TransportType.ServerSentEvents, MessageBusType.Fake)]
         [InlineData(HostType.Memory, TransportType.ServerSentEvents, MessageBusType.FakeMultiStream)]