Modified SignalRError

#1908
SignalR · Apr 29, 2013 · eaca449 · eaca449
1 parent 81538f0
commit eaca449
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 18 deletions.
diff --git a/src/Microsoft.AspNet.SignalR.Client/Infrastructure/ErrorExtensions.cs b/src/Microsoft.AspNet.SignalR.Client/Infrastructure/ErrorExtensions.cs
@@ -48,7 +48,7 @@ private static SignalRError GetWebExceptionError(Exception ex)
 
                 if (response != null)
                 {
-                    error.SetHttpWebResponse(response);
+                    error.SetResponse(response);
                     error.StatusCode = response.StatusCode;
                     Stream originStream = response.GetResponseStream();
 
@@ -82,7 +82,7 @@ private static SignalRError GetHttpClientException(Exception ex)
 
                 if (response != null)
                 {
-                    error.SetResponseMessage(response);
+                    error.SetResponse(response);
                     error.StatusCode = response.StatusCode;
                     error.ResponseBody = response.Content.ReadAsStringAsync().Result;
                 }

diff --git a/src/Microsoft.AspNet.SignalR.Client/Infrastructure/SignalRError.cs b/src/Microsoft.AspNet.SignalR.Client/Infrastructure/SignalRError.cs
@@ -11,8 +11,7 @@ namespace Microsoft.AspNet.SignalR.Client
     /// </summary>
     public class SignalRError : IDisposable
     {
-        private HttpWebResponse _responseWeb;
-        private HttpResponseMessage _responseMessage;
+        private IDisposable _response;
 
         /// <summary>
         /// Create custom SignalR based error.
@@ -23,14 +22,9 @@ public SignalRError(Exception exception)
             Exception = exception;
         }
 
-        internal void SetHttpWebResponse(HttpWebResponse response)
+        internal void SetResponse(IDisposable response)
         {
-            _responseWeb = response;
-        }
-
-        internal void SetResponseMessage(HttpResponseMessage response)
-        {
-            _responseMessage = response;
+            _response = response;
         }
 
         /// <summary>
@@ -61,14 +55,9 @@ protected virtual void Dispose(bool disposing)
         {
             if (disposing)
             {
-                if (_responseWeb != null)
-                {
-                    _responseWeb.Close();
-                }
-
-                if (_responseMessage != null)
+                if (_response != null)
                 {
-                    _responseMessage.Dispose();
+                    _response.Dispose();
                 }
             }
         }