Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't catch exceptions thrown from user-defined OnReceived handlers on the JS client #1530

Closed
halter73 opened this issue Feb 15, 2013 · 1 comment
Closed

Don't catch exceptions thrown from user-defined OnReceived handlers on the JS client #1530

halter73 opened this issue Feb 15, 2013 · 1 comment
Assignees
@halter73
Labels
type: Bug
Milestone
1.0.1

Comments

@halter73
Copy link
Member

Today we capture exceptions thrown by user code handling receive events and then call the user's error handler(s) with the exception if any error handler(s) exist. The users should be responsible for ensuring that they don't throw any uncaught exceptions in their handlers.
@ghost ghost assigned halter73 Feb 15, 2013
halter73 added a commit that referenced this issue Feb 15, 2013
@halter73
Don't catch exceptions thrown from client OnReceived handlers
1caf691 
#1530
@halter73 halter73 mentioned this issue Feb 16, 2013
Merged
halter73 added a commit that referenced this issue Feb 16, 2013
@halter73
Don't catch exceptions thrown from onReceived handlers in JS
3d2b82b 
- We still catch these exceptions in the .NET client since there seems
  to be no better way to allow developers to observe exceptions thrown
  in the Received handler

#1530
halter73 added a commit that referenced this issue Feb 18, 2013
@halter73
Don't catch exceptions thrown from onReceived handlers in JS
58c9a6e 
- We still catch these exceptions in the .NET client since there seems
  to be no better way to allow developers to observe exceptions thrown
  in the Received handler

#1530
@Xiaohongt
Copy link
Contributor

verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@halter73 halter73

Labels
type: Bug
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
2 participants
@halter73 @Xiaohongt