Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RedisMessageBus to use latest version of Booksleeve #1788

Closed
MosheL opened this issue Apr 2, 2013 · 8 comments
Closed

Update RedisMessageBus to use latest version of Booksleeve #1788

MosheL opened this issue Apr 2, 2013 · 8 comments
Assignees
@davidfowl
Labels
type: Bug
Milestone
1.1.0 RTW

Comments

@MosheL
Copy link

MosheL commented Apr 2, 2013

The problem is the pub/sub in Booksleeve, that changed in the new version:

http://code.google.com/p/booksleeve/source/detail?r=4c6199411b64f86454249ffdda03dfd085e6a60b
@davidfowl
Copy link
Member

Did you manually update book sleeve or did NuGet bring in an incompatible version?

@MosheL
Copy link
Author

MosheL commented Apr 2, 2013

I was updated manualy (from NuGet also, as I want to test other features of 1.3x). NuGet is OK.

@davidfowl
Copy link
Member

This will get resolved in a later release then.

@ghost ghost assigned davidfowl Apr 2, 2013
@niemyjski
Copy link

Will this make it into the 1.2 beta/release?

@davidfowl
Copy link
Member

@niemyjski are you missing a specific feature? Or are you using booksleeve and now you can't because it's not using the latest?

@niemyjski
Copy link

We are using booksleeve and it should be easy to upgrade signalr to the latest version.

@davidfowl
Copy link
Member

@niemyjski funnily enough, the latest version has some functional breaking changes which is why we didn't upgrade in the first place. We'll circle back and see if it's worth the upgrade this release.

davidfowl added a commit that referenced this issue Apr 21, 2013
@davidfowl
Overhauled RedisMessageBus using newer version of booksleeve.
78ed74c 
- Use transactions per save so that increments happen in
  the right order.
- Updated to use the latest version of Booksleeve.
- Set the subscription mode to preserve order.

#1676
#1788
@davidfowl davidfowl mentioned this issue Apr 21, 2013
Merged
@Xiaohongt
Copy link
Contributor

verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidfowl davidfowl

Labels
type: Bug
Projects
None yet
Milestone
1.1.0 RTW
Development

No branches or pull requests
4 participants
@davidfowl @niemyjski @MosheL @Xiaohongt