Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax conditions under which errors are thrown for invoking callback methods on the client #2203

Closed
davidfowl opened this issue Jun 25, 2013 · 1 comment
Assignees
Milestone

Comments

@davidfowl
Copy link
Member

In #1958 we changed the client callbacks to always throw if arguments don't match. This causes a bunch of different issues as it's too strict. This means the server can't change the call site Clients.All.foo(x) to Clients.All.foo(x,y) without changing all clients (which might not be possible). Instead, we should only fail if the number of expected arguments is less.

We should also improve the errors for conversion of arguments specifying which arguments failed to convert to which types.

@gustavo-armenta
Copy link
Contributor

verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants