Relax conditions under which errors are thrown for invoking callback methods on the client #2203

Closed
davidfowl opened this Issue Jun 25, 2013 · 1 comment

Projects

None yet

3 participants

@davidfowl
Member

In #1958 we changed the client callbacks to always throw if arguments don't match. This causes a bunch of different issues as it's too strict. This means the server can't change the call site Clients.All.foo(x) to Clients.All.foo(x,y) without changing all clients (which might not be possible). Instead, we should only fail if the number of expected arguments is less.

We should also improve the errors for conversion of arguments specifying which arguments failed to convert to which types.

@abnanda1 abnanda1 was assigned Jun 25, 2013
@abnanda1 abnanda1 added a commit that referenced this issue Jun 25, 2013
@abnanda1 abnanda1 Reverted the breaking change where we throw if a callback with fewer …
…arguments is encountered

#2203
55efb59
@abnanda1 abnanda1 added a commit that referenced this issue Jun 26, 2013
@abnanda1 abnanda1 Reverted the breaking change where we throw if a callback with fewer …
…arguments is encountered

#2203
104f32f
@gustavo-armenta

verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment