Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The .NET 4.5 C# client leaks connections given responses with non-successful status code #4092

Closed
halter73 opened this issue Mar 31, 2018 · 0 comments · Fixed by #4222
Closed

Comments

@halter73
Copy link
Member

Expected behavior

When a request made by the .NET 4.5 SignalR client fails due to a non-successful status code, the underlying connection should be gracefully closed by the time the SignalR client enters the disconnected state.

Actual behavior

The underlying connection stays open because response was never disposed prior to throwing here and here. This can lead to a large number of open connections in combination with manual reconnect logic.

image

Steps to reproduce

Repeatedly attempt to connect (i.e manual reconnect logic) to a SignalR endpoint that responds with a 401 from the /negotiate.

@davidfowl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants