Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2189 - Modified when we clear private non timeout based state #2435

Closed
wants to merge 2 commits into from
Closed

2189 - Modified when we clear private non timeout based state #2435

wants to merge 2 commits into from

Conversation

NTaylorMullen
Copy link
Contributor

This ensures that when we start -> stop -> start that all deferred's are triggered correctly.
#2189

@NTaylorMullen
Re-ordered when we clear private non-timeout based state.
9e59d41 
- This way we can successfully reject connection deferrals.

#2189
@NTaylorMullen
Added a test to verify when we start->stop->start that all deferred's…
b632a09 
… are rejected or resolved correctly.

#2189
@halter73
Copy link
Member

Looks good.

@davidfowl
Copy link
Member

+1 :shipit:

@NTaylorMullen
Copy link
Contributor Author

This is in already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NTaylorMullen @halter73 @davidfowl