2506 - Added error handling for invalid json responses #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NTaylorMullen
commented
Oct 24, 2013
NTaylorMullen
commented
- This change also works to fix bad 3xx redirects as noted in Hub calls should fail if request's response is 3xx redirect #2506.
| } | ||
| initialConnectedFired = true; | ||
| onSuccess(); | ||
| tryFailConnect = fireConnect = $.noop; |
There was a problem hiding this comment.
I don't think that it is necessary to have tryFailConnect in this assignment. By nulling out onFailed at the end of this function, you are causing tryFailConnect to noop anyway and actually return false. $.noop does not return a value.
Also, can fireConnect ever be fired after tryFailConnect succeeded? If so, onSuccess will still be called which I don't think is right.
- When an error occurs, instead of throwing ot the window object we now handle it appropriately. #2506
…rifying parse responses is handled correctly when it throws. - Also added the wrapStart functionality to the JS test utilities #2506
… error handler and stop the connection. #2506
- If transports fail to parse a response while in connecting they will now fall back. - Centralized this logic in the common.js #2506
…hile connecting indeed do fall back. - Also fixed some long polling logic #2506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.