Allow HubConnections to be used in Crank #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created IConnectionFactory as injection point for developers to customize how a Connection is created - Created DefaultConnectionFactory to retain behavior of creating a regular Connection - Modified Crank client to compose the IConnectionFactory dependency using MEF. If no candidate is supplied by an external assembly, the client will automatically use the DefaultConnectionFactory SignalR#3000
|
@ermontgo Did you sign a CLA? |
|
Yes I have. I have the confirmation email and info if you need anything. |
|
@davidfowl @pfletcher CLA is confirmed. |
|
Verified that factory composition works with both default and custom factories. |
mikary
added a commit
that referenced
this pull request
Oct 10, 2014
Allow HubConnections to be used in Crank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
customize how a Connection is created
regular Connection
using MEF. If no candidate is supplied by an external assembly, the
client will automatically use the DefaultConnectionFactory
Crank: Update tool to use Hubs connection instead of just PersistentConnection #3000