Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stay in edit mode after adding a note or a 'relation to other sign' #477

Closed
Woseseltops opened this issue Aug 2, 2018 · 9 comments
Closed
Assignees

Comments

@Woseseltops
Copy link
Collaborator

Usability thingy mentioned by Julie.

@Woseseltops Woseseltops changed the title Stay in edit mode after adding a 'relation to other sign' Stay in edit mode after adding a note or a 'relation to other sign' Aug 2, 2018
@ocrasborn
Copy link
Collaborator

Agree, would be useful.

@susanodd
Copy link
Collaborator

susanodd commented Aug 2, 2018

This is something I did when we added ajax calls to the database.
It used to be that staying in edit mode was triggered by "?edit ...." appearing at the end of the URL.
Do you mind if this is visible in the URL? I'll put it back.

@susanodd
Copy link
Collaborator

susanodd commented Aug 2, 2018

I'm looking at this now, what the update.py code used to be. Depending on the type of update, ?edit... is added.
The gloss_edit.js code is what processes the ?edit part to keep the respective section being edited open.
(e.g., ?editrel, ?editrelforeign, ?editdef, ?editmorphdef, ?editothermedia)
But one thing that has changed since then are the dataset permissions.
Having an "?edit" at the end of the URL should not work if somebody just types the URL without being in the middle of editing.
(It shouldn't be possible for a user to start editing just by putting ?edit at the end of the URL.)
Hopefully Django will catch this. We probably need a test for this. (After the code is restored.)

susanodd pushed a commit that referenced this issue Aug 2, 2018
@susanodd
Copy link
Collaborator

susanodd commented Aug 2, 2018

Okay, so far I fixed this for Relations to Other and to Foreign signs.

@susanodd susanodd self-assigned this Aug 2, 2018
@susanodd
Copy link
Collaborator

susanodd commented Aug 3, 2018

This has been fixed. Pushed to github.

@Woseseltops
Copy link
Collaborator Author

Hey @susanodd , I just put the latest version on the live server, but there it doesn't work work for the two types of relations (does work for notes, though). Any idea what is going on there?

@susanodd
Copy link
Collaborator

I see that. Hmm.

@susanodd
Copy link
Collaborator

Okay, I just fixed it. I didn't catch a couple of the reverse redirects after updates.

@susanodd
Copy link
Collaborator

Pushed to github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants