-
Notifications
You must be signed in to change notification settings - Fork 44.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest alpine image for code execution #1192
Use latest alpine image for code execution #1192
Conversation
6c31426
to
0610968
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests and image name changes are unrelated. Submit them apart in separate PRs.
Also besides alipne there are debian slim images and other options. At least keep Python version pinned.
a68ce58
to
573af28
Compare
@nponeccop I've split the PRs, will submit the test separately. Alpine is the smallest image, hence I chose alpine. When it comes to the version - the code generated by GPT can reasonably be assumed to use the latest python features, that's why I think we should use the latest version. I've pinned the major (3) although Python 4 ever coming out is (according to Guido) rather doubtful. |
Latest as of the training data, that is Sep 2021. I've just asked GPT+ if you are curious. Q: What is the latest version of Python you are aware of? 3.5: As of my knowledge cutoff date of September 2021, the latest version of Python is 3.10.0, which was released on October 4, 2021. 4: As of my knowledge cutoff date in September 2021, the latest version of Python was Python 3.9. Further investigation is needed, maybe 4 is just smarter to detect the contradiction but it's actually aware of 3.10 So this particular argument for the latest version doesn't hold. |
3.x should be backwards-compatible anyway. |
Yes, there are other arguments in favor of the latest python, just not the GPT generated code one. |
You're right. |
573af28
to
5389b2d
Compare
@nponeccop same change applied to the refactored code, please review again. Sorry to bother you, but the codebase is changing from right under me. |
@rickythefox There are conflicts now |
@nponeccop fixed |
@rickythefox There are conflicts now |
cdb397c
to
434c4a1
Compare
@nponeccop fixed (jesus christ this is changing fast) |
@rickythefox There are conflicts now |
@nponeccop fork synked |
@nponeccop merged again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Background
Currently code execution uses a fat python 3.10 image.
Changes
This PR replaces it with the smaller and newer 3.11 alpine image. This also ensures that an update to newer python versions will happen automatically as the
alpine
tag uses the latest stable python version.Documentation
N/A
Test Plan
Integration test included.
PR Quality Checklist