-
Notifications
You must be signed in to change notification settings - Fork 44k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add further step to avoid message summary from breaking #3923
add further step to avoid message summary from breaking #3923
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3923 +/- ##
==========================================
- Coverage 60.99% 60.91% -0.09%
==========================================
Files 73 73
Lines 3310 3316 +6
Branches 542 542
==========================================
+ Hits 2019 2020 +1
- Misses 1152 1157 +5
Partials 139 139
☔ View full report in Codecov by Sentry. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Isnt that obsolete now? |
Background
It is already known that message summary could break or overwrite the message history,
I encountered a few problems which these two changes fix.
Changes
Documentation
Test Plan
PR Quality Checklist