Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate agent toolkits from langchain #7

Closed
claysauruswrecks opened this issue Mar 29, 2023 · 4 comments
Closed

Incorporate agent toolkits from langchain #7

claysauruswrecks opened this issue Mar 29, 2023 · 4 comments
Labels
wontfix This will not be worked on

Comments

@claysauruswrecks
Copy link

https://python.langchain.com/en/latest/modules/agents/toolkits.html

@dschonholtz
Copy link
Contributor

Yohei over on Twitter recently torched all of the lang chain agent work to slim down the code.
In theory the reAct framework will give better results but I think a version of that is currently running here.

What specifically would the goal of incorporating agents from lang chain accomplish?

@claysauruswrecks
Copy link
Author

@dschonholtz - Sorry, I'm not following. I opened this issue early in the project's existence. Can you link the changes you're talking about?

@dschonholtz
Copy link
Contributor

I was referring to a separate project where a dev pointed out that they could make their project a lot more lean by ripping out lang chain.
I just wanted to ask what the intended value add was for adding lang chain agents was before they get pulled in.
ReAct agents or some of the other langchain agents have been shown to perform well. But it would be good to identify why we want to add them before we pull them in over the current system that works fairly well considering it might add bloat without performance improvement

@ryanpeach
Copy link
Contributor

Think it's very premature to say "wont-fix" on langchain. Lanchain adds the ability to add tools from large pre-built toolkits, integrate other LLMs, and switch to other prompting styles via it's AGENT_TYPE enum.

Not using it is basically the equivalent of announcing you plan to not keep up with the latest open source contributions and research in LLMs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants