Possible workaround for #796 #1302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sean19899999
previously approved these changes
Apr 16, 2023
Berserker66
reviewed
Apr 16, 2023
|
@esurharun There are conflicts now |
Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com>
github-actions
bot
added
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
3 similar comments
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
@esurharun Sorry it's our bot went crazy. We'll sort it out. |
github-actions
bot
removed
the
conflicts
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
|
Can't wait for this to be approved. Huge blocker to awesome things :-) |
|
Fixed in #2542. Thanks for submitting though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Please check out issue #796
Changes
Just applied OpenAI cookbook at https://github.com/openai/openai-cookbook/blob/main/examples/Embedding_long_inputs.ipynb
PR Quality Checklist
I just coded to speed up to the full fix. It needs to get revized and considered for Azure option too.