Add the ability to capture and load snapshots of memory and message history #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberney
reviewed
Apr 6, 2023
| @@ -114,10 +114,10 @@ def chat_with_ai( | |||
| ) | |||
|
|
|||
| # Update full message history | |||
| full_message_history.append( | |||
| message_history.append( | |||
There was a problem hiding this comment.
Is this a significant or required change?
| @@ -178,14 +177,14 @@ def get_hyperlinks(url): | |||
|
|
|||
| def commit_memory(string): | |||
| _text = f"""Committing memory with string "{string}" """ | |||
| mem.permanent_memory.append(string) | |||
| memory.append(string) | |||
There was a problem hiding this comment.
Nice, the stuff in this area makes sense to me.
| class DataStore(): | ||
|
|
||
| def persist_message_history(self, id): | ||
| return True |
There was a problem hiding this comment.
What about return False on everything for the abstract base class? Or if errors are involved, throwing the NotImplementedError?
| message_history.set_history(f["message_history"]) | ||
| return True | ||
| except Exception as e: | ||
| return e |
There was a problem hiding this comment.
This function returns either True or Error. Both a consistent boolean or an actual exception is better if you ask me.
| @@ -248,6 +252,9 @@ def parse_arguments(): | |||
| parser.add_argument('--speak', action='store_true', help='Enable Speak Mode') | |||
| parser.add_argument('--debug', action='store_true', help='Enable Debug Mode') | |||
| parser.add_argument('--gpt3only', action='store_true', help='Enable GPT3.5 Only Mode') | |||
| parser.add_argument('--enable-snapshots', action='store_true', help='Enable Snapshots') | |||
| parser.add_argument('--snapshot-path', type=str, default=None, required=False, help='Path for the snapshot directory') | |||
| parser.add_argument('--snapshot-id', type=str, default=None, required=False, help='ID of the snapshot to load') | |||
|
Can you rebase it on the current master? |
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Say383
pushed a commit
to Say383/Auto-GPT
that referenced
this pull request
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
#9 #122 #124 #125
Primary discussion here:
#124 (comment)
TODO:
Tests
Code review
Improve code quality