Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up the memory functionality #213

Closed
wants to merge 1 commit into from
Closed

Cleaned up the memory functionality #213

wants to merge 1 commit into from

Conversation

Riddle1001
Copy link

I moved the memory functionality into it's own file, and made it a singleton. Works as expected.

@jfhutchi
Copy link

jfhutchi commented Apr 6, 2023

Why did you remove .env.template?

@sberney
Copy link

sberney commented Apr 6, 2023

Why did you make it into a class if it's also a singleton? What new functionality or capability does this add?

@bnuttall
Copy link

bnuttall commented Apr 6, 2023

I think this commit is now overtaken by events, as Pinecone seems to have been merged into the master branch

@Riddle1001
Copy link
Author

Why did you remove .env.template?

I will fix this, didnt notice thanks,

Why did you make it into a class if it's also a singleton? What new functionality or capability does this add?

In python, you cannot make a singleton without it being a class, and vice versa. Singleton is a design pattern and wouldn't add any functionality.

@nponeccop
Copy link
Contributor

@Riddle1001 Fix the .env issue and resolve the conflicts

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 17, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

1 similar comment
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@k-boikov
Copy link
Contributor

This PR is completely obsolete, memory module has been rewritten.

tgonzales pushed a commit to tgonzales/Auto-GPT that referenced this pull request Apr 19, 2023
@Jshen123
fix(Significant-Gravitas#213): update temperature tooltip (Significan…
0e47bf8 
…t-Gravitas#222)

* remove english in chinese readme

* make more temperature more descriptive

* Revert "remove english in chinese readme"

This reverts commit a8f2ecd4b972a9b5fc3282b0efd54c1d37c53d46.
@p-i-
Copy link
Contributor

p-i- commented May 5, 2023

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

@Pwuts
Copy link
Member

Pwuts commented Jun 14, 2023

As @k-boikov mentioned, the memory module has been rewritten completely (#4208), so this PR is obsolete. Thanks for submitting though!

@Pwuts Pwuts closed this Jun 14, 2023
waynehamadi added a commit that referenced this pull request Sep 5, 2023
@waynehamadi
Use Auto-GPT master (#213)
b71aec4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conflicts Automatically applied to PRs with merge conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Riddle1001 @jfhutchi @sberney @bnuttall @nponeccop @k-boikov @p-i- @Pwuts