-
Notifications
You must be signed in to change notification settings - Fork 43.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial base.py for message broker agent-state-encapsulation #3831
Initial base.py for message broker agent-state-encapsulation #3831
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
autogpt/core/messaging/base.py
Outdated
|
||
class MessageCategory(Enum): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The distinction between message category and role seems fuzzy. Ie can a user only send USER_INPUT
messages? can the SYSTEM/ASSISTANT send anything but USER_PROMPT
?
pass | ||
|
||
@dataclasses.dataclass | ||
class Message(ABC): # ABC should be within parentheses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recall that we've got a message struct elsewhere. It's good not to pollute our own types namespace. We should rename one or both of these (probably keep this one and rename the other, but interested to hear other opinions)
autogpt/core/messaging/base.py
Outdated
message: str | ||
kind_of_message: MessageCategory | ||
|
||
class MessageBroker(ABC): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs some discussion and work I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also has the fuzziest scope. We maybe leave this PR til the end of the abstractions since its the most new feature kind of thing we're adding and it'll be easier to think about with the other systems resolved.
What does this do? Is this an abstraction of a prompt handler? |
It's an interface for the message broker @anonhostp |
2afe06a
into
Significant-Gravitas:agent-state-encapsulation
Hmmm, I'm guessing I'm unsure what the "message broker" is. It sounds like an object that controls sending messages back and forth between the APIs. I guess I'll figure out what it actually does in a bit, once I'm done scrubbing the repo. Just wanted to see if I could probe your knowledge a bit now, but thank you though! |
it's for the inter-agent messaging API - which currently is NOT yet an API ...I wanted to use that, when I learnt that isn't even yet a proper encapsulated API - so that's probably what they're now working on fixing |
Background
Changes
Documentation
Test Plan
PR Quality Checklist