-
Notifications
You must be signed in to change notification settings - Fork 42.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add command shell blacklist and whitelist #3950
add command shell blacklist and whitelist #3950
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3950 +/- ##
==========================================
- Coverage 62.91% 62.66% -0.25%
==========================================
Files 74 74
Lines 3400 3426 +26
Branches 495 504 +9
==========================================
+ Hits 2139 2147 +8
- Misses 1112 1123 +11
- Partials 149 156 +7
☔ View full report in Codecov by Sentry. |
Deployment failed with the following error:
|
Echoing the sentiment from #2644. The proposal to use "denylist" and "allowlist" instead of "blacklist" and "whitelist" was made to encourage more inclusive language in the codebase. These terms are considered more neutral alternatives. |
In the code it says allow and deny already. |
Deployment failed with the following error:
|
Deployment failed with the following error:
|
Deployment failed with the following error:
|
bf33f4a
into
Significant-Gravitas:master
Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> Co-authored-by: Nicholas Tindle <nick@ntindle.com> Co-authored-by: Richard Beales <rich@richbeales.net>
Background
There is only a command category whitelist and blacklist.
Changes
Added the ability to restrict shell_commands by keywords, to avoid that the instance keeps running into ui interfaces that have no return.
Documentation
Add your list of keywords to be forbidden.
When you add a keyword to the whilelist, only those keywords from the whitelist are allowed.
Test Plan
PR Quality Checklist