Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent docker compose to break config by creating folders #4125

Merged

Conversation

k-boikov
Copy link
Contributor

Background

Docker compose will create folders instead of file for volumes if they do not exist on the host. That would cause error on start:
image

Changes

Switch the Volume type in docker-compose.yml documentation to use bind type. That would require users to have the files already created.
image
Added default values to be empty dictionary in case uses have created the files but left them empty preventing this error:
image

Linked issues:

#3052

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 22, 2023 10:30am

@k-boikov k-boikov changed the title prevent docker compose to break config by creating folders Prevent docker compose to break config by creating folders May 11, 2023
@vercel vercel bot temporarily deployed to Preview May 11, 2023 20:24 Inactive
@k-boikov k-boikov added setup Issues with getting Auto-GPT setup on local machines docker labels May 11, 2023
@k-boikov k-boikov requested a review from waynehamadi May 11, 2023 20:29
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.22 🎉

Comparison is base (dcb1cbe) 64.53% compared to head (7837fce) 64.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4125      +/-   ##
==========================================
+ Coverage   64.53%   64.76%   +0.22%     
==========================================
  Files          75       75              
  Lines        3542     3542              
  Branches      520      520              
==========================================
+ Hits         2286     2294       +8     
+ Misses       1086     1078       -8     
  Partials      170      170              
Impacted Files Coverage Δ
autogpt/config/ai_config.py 82.53% <100.00%> (+3.17%) ⬆️
autogpt/config/config.py 77.27% <100.00%> (+3.40%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added size/l and removed size/m labels May 11, 2023
@Wladastic
Copy link
Contributor

Maybe just my 2 cents.. what if we specifically check for those files on start and tell the user specifically that those are missing?
Most users don't read the stacktrace, like ever^^

@k-boikov
Copy link
Contributor Author

Maybe just my 2 cents.. what if we specifically check for those files on start and tell the user specifically that those are missing? Most users don't read the stacktrace, like ever^^

The AI config is ok to be missing in the general case, it will be created. For azure - that must be there if you want to use azure. The issue is that I cannot test azure and afaik it has been broken in the last couple of releases. Feel free to make a PR if you want.

@vercel vercel bot temporarily deployed to Preview May 15, 2023 22:43 Inactive
@k-boikov k-boikov added this to the v0.3.2 Release milestone May 17, 2023
@vercel vercel bot temporarily deployed to Preview May 17, 2023 23:33 Inactive
@lc0rp lc0rp requested a review from Wladastic May 19, 2023 13:44
@lc0rp
Copy link
Contributor

lc0rp commented May 19, 2023

@Wladastic happy to approve and get this in v0.3.2? I'll float it by azure testers

@github-actions
Copy link

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 21, 2023
@github-actions
Copy link

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label May 21, 2023
@vercel vercel bot temporarily deployed to Preview May 21, 2023 00:44 Inactive
@ntindle
Copy link
Member

ntindle commented May 21, 2023

I got azure access but it costs a fortune to keep up all the time. Let me know if you need keys or me to test. Azure works fine right now as far as I can tell. The docs are just bad

@k-boikov
Copy link
Contributor Author

or me to test. Azure works fine right now as far as I can tell. The docs are just bad

Then I think we are good to merge. There is nothing here to test with the actual azure.

Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it but it looks good

@k-boikov k-boikov merged commit 360d5cd into Significant-Gravitas:master May 22, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker setup Issues with getting Auto-GPT setup on local machines size/l
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants