Refactor challenges to use cycle count instead of time #4222
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size |
waynehamadi
force-pushed
the
feature/refactor-tests
branch
from
a76687b
to
3c991b1
Compare
|
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size |
waynehamadi
force-pushed
the
feature/refactor-tests
branch
from
3c991b1
to
b74b0ef
Compare
|
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size |
waynehamadi
force-pushed
the
feature/refactor-tests
branch
from
b74b0ef
to
0e53cbf
Compare
|
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size |
waynehamadi
force-pushed
the
feature/refactor-tests
branch
from
0e53cbf
to
ee61e79
Compare
github-actions
bot
removed
the
conflicts
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
|
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size |
waynehamadi
force-pushed
the
feature/refactor-tests
branch
from
ee61e79
to
d728edd
Compare
|
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4222 +/- ##
==========================================
+ Coverage 62.09% 62.33% +0.23%
==========================================
Files 73 73
Lines 3327 3329 +2
Branches 479 480 +1
==========================================
+ Hits 2066 2075 +9
+ Misses 1122 1107 -15
- Partials 139 147 +8
☔ View full report in Codecov by Sentry. |
waynehamadi
force-pushed
the
feature/refactor-tests
branch
from
d728edd
to
091a633
Compare
|
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size |
waynehamadi
force-pushed
the
feature/refactor-tests
branch
from
091a633
to
88e4f5b
Compare
|
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size |
|
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size |
waynehamadi
changed the title
|
Could you describe exactly what the cycle count is doing? |
|
Generally this seems like a good thing |
|
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size |
…ravitas#4222) Co-authored-by: Richard Beales <rich@richbeales.net>
Background
Continuous agents need to be stopped after a certain time, but we don't know that time in advance.
Plus there could be some rate limit errors that make the agent take more time.
So instead of using time let's use the number of cycle.
Other code cleanup added.
Changes
use cycle count instead of time
enforce type hinting on challenges
create a test for challenges to be formatted properly (it's a test testing the tests)
Documentation
Test Plan
PR Quality Checklist